#148 No way to install system-wide plugins
Closed: Fixed None Opened 11 years ago by sochotni.

Currently plugins get installed in site-packages/plugins/ which is itself not good. What is worse this is python-specific and so shell_api plugin will try to search site-packages/scripts for shell scripts to execure as plugins.

This is really bad from packaging point of view as well


Trying to sort this out:

There are three types of plugins: python, shell and json. I suggest we use these names, trying to avoid still more confusion...

  • python plugins: As released, personal plugins in ~/.local/share/fedora-review/plugins was not
    loaded as described in manpage. Fixed in commit below.
  • shell and python plugins: Site-wide plugins are loaded from application directory, the subject of
    this bug. As discussed, this could be resolved using symlinks in the installed package. Using the
    application-relative link is a huge advantage when developing and testing git variants.
  • JSON plugins. The load path was broken. System-wide plugins (which does not exist) are loaded from
    new top directory 'json-plugins'. This is actually aimed to be linked to /usr/share/f-r/plugins.
    JSON plugins are assumed not to have a .py extension.

Commit: a5dd250

Pushed updated branch vers-info. This enables post-release rpms, and fixes linking in the specfile. The branch is rebased on fix-plugin-loading branch.

Fixed in 0.3.1, several commits

Login to comment on this ticket.

Metadata