#13 Improve find_tag to optionally return expanded macros
Closed: Fixed None Opened 12 years ago by sochotni.

$subj would be useful in various parts of the code (and JSON api)


Even more useful after recent changes in the guidelines allowing the use of explicit directory paths instead of macros. Notably, /etc can be used instead of %_sysconfdir. This means that in many cases where we expect a macro, there might be a path.

One way to handle this could be to generate an expanded spec file (using rpmspec -P) and parse this instead. Even though there is a need for the raw data, e. g, when checking for macros, this is really the exception and not the general need.

Fixed in c52f577. The outstanding issue is that rpm needs to be patched in order to return also expanded directory paths: https://bugzilla.redhat.com/show_bug.cgi?id=857653

EDIT: fix above does expand directory paths, even without the rpm patch. There are corner cases (%_datadir will not work, %{_datadir} does), but this is basically fixed. So, this bug can be closed IMHO

I'm closing this since we always are using expanded paths now.

Login to comment on this ticket.

Metadata