Issue #126: Deprecations in shell scripts are sometimes skipped - FedoraReview

FedoraReview

#126 Deprecations in shell scripts are sometimes skipped

Closed: Invalid None Opened 11 years ago by sochotni.

I have created shell script which should deprecate CheckSoFiles, but even though fedora-review -d lists my check as deprecating CheckSoFiles, the original CheckSoFiles is being run anyway.

Attached is my script

sochotni commented 11 years ago

attachment
check-perl-so.sh

leamas commented 11 years ago

I have found a problem in the perl module I proposed. Attaching new version.

When using this, I cannot reproduce the problems on bug 812586 . Details:

I have patched the shell script, new version attached. This one produces a log and also dumps
the environment.
From the dumped environment and the logs it's obvious that the unpack_rpms function works out
of the box
From the log in ~/.cache/ I cannot see any invocation of CheckSoFiles.

I'm a bit worried: the bad perl module file caused a printout on stdout. Did you have this?
{{{
Illegal group Perl in /home/leamas/fedorahosted/tmp/FedoraReview/scripts/perl-check-sofiles.sh
}}}

leamas commented 11 years ago

Revised perl module
perl.py

leamas commented 11 years ago

Revised shellscript
perl-check-sofiles.sh

leamas commented 11 years ago

set -x log from shellscript
slask.log

leamas commented 11 years ago

dumped environment from shellscript
slusk.log

leamas commented 11 years ago

I have added a testcase using --prebuilt --name and a shellscript deprecation. Tentatively closing bug but, of course :), feel free top reopen...

leamas commented 11 years ago

The testcase: ccd27b2