From 9ec2bef0a95bf5779b50727b871288c80f408b54 Mon Sep 17 00:00:00 2001 From: Fabrice BAUZAC-STEHLY Date: Feb 24 2021 20:20:28 +0000 Subject: Remove CheckInfoInstall. Info files are now implicitly handled because of their pathname. It is now unnecessary to place explicit %post or %preun scriptlets anymore. --- diff --git a/plugins/generic.py b/plugins/generic.py index c061773..0b95dfa 100644 --- a/plugins/generic.py +++ b/plugins/generic.py @@ -1911,38 +1911,6 @@ class CheckGconfSchemaInstall(GenericCheckBase): self.set_passed(self.FAIL if failed else self.PENDING, text) -class CheckInfoInstall(GenericCheckBase): - """ Check that info files are properly installed. """ - - def __init__(self, base): - GenericCheckBase.__init__(self, base) - self.url = ( - "https://docs.fedoraproject.org/en-US" - "/packaging-guidelines/Scriptlets/#_texinfo" - ) - self.text = ( - "Texinfo files are installed using install-info" - " in %post and %preun if package has .info files." - ) - self.automatic = True - self.type = "MUST" - - def run(self): - using = [] - failed = False - for pkg in self.spec.packages: - if self.rpms.find("/usr/share/info/*", pkg): - using.append(pkg) - rpm_pkg = self.rpms.get(pkg) - if not in_list("install-info", [rpm_pkg.post, rpm_pkg.preun]): - failed = True - if not using: - self.set_passed(self.NA) - return - text = "Texinfo .info file(s) in " + ", ".join(using) - self.set_passed(self.FAIL if failed else self.PENDING, text) - - class CheckGdkPixbufLoaders(GenericCheckBase): """ Check that gdk-pixbuf-query-loaders is run if required. """ diff --git a/test/test_checks.py b/test/test_checks.py index cad1b04..e609911 100644 --- a/test/test_checks.py +++ b/test/test_checks.py @@ -312,7 +312,6 @@ class TestChecks(FR_TestCase): ("fail", "CheckGtkQueryModules"), ("fail", "CheckGioQueryModules"), ("fail", "CheckUpdateIconCache"), - ("fail", "CheckInfoInstall"), ("fail", "CheckGlibCompileSchemas"), ("fail", "CheckUpdateMimeDatabase"), ("pending", "CheckBundledFonts"), @@ -333,7 +332,6 @@ class TestChecks(FR_TestCase): ("pending", "CheckGtkQueryModules"), ("pending", "CheckGioQueryModules"), ("pending", "CheckUpdateIconCache"), - ("pending", "CheckInfoInstall"), ("pending", "CheckGlibCompileSchemas"), ("pending", "CheckUpdateMimeDatabase"), ("pending", "CheckBundledFonts"),