From 771afffda192de9dd13ee993a0b4807ab58a95f0 Mon Sep 17 00:00:00 2001
From: Miro Hrončok <miro@hroncok.cz>
Date: Dec 11 2024 17:17:24 +0000
Subject: Do not report unsolvable Requires as deprecated


When a Requires was not found, the for loop never run,
hence the else branch was executed.

This was wrong. Especially when testing packages with not-yet-available deps,
those would be always reported as deprecated()

---

diff --git a/plugins/generic.py b/plugins/generic.py
index 1c3505e..9aad887 100644
--- a/plugins/generic.py
+++ b/plugins/generic.py
@@ -2169,15 +2169,16 @@ class CheckIfDepsDeprecated(GenericCheckBase):
         pkg_list |= set(self.spec.build_requires_nevrs)
 
         for dependency, providers in resolve_as_groups(pkg_list).items():
-            for pkg in providers:
-                provides = deps.list_provides(pkg)
-                if all("deprecated()" not in p for p in provides):
-                    break
-            else:
-                self.set_passed(
-                    self.FAIL, dependency + " is deprecated, you must not depend on it."
-                )
-                return
+            if providers:
+                for pkg in providers:
+                    provides = deps.list_provides(pkg)
+                    if all("deprecated()" not in p for p in provides):
+                        break
+                else:
+                    self.set_passed(
+                        self.FAIL, dependency + " is deprecated, you must not depend on it."
+                    )
+                    return
 
         self.set_passed(self.PASS)