From 331376314e964716db6fd9c7b88a858dcbf39d88 Mon Sep 17 00:00:00 2001 From: Michael Scherer Date: Jul 23 2012 10:48:43 +0000 Subject: Remove dead code, __download_sources always return True, so no need to check return code, and this permit to fix #82 ( and avoid downloading the code twice ). The upstream tarball check is already done by rpmlint. --- diff --git a/src/FedoraReview/review_helper.py b/src/FedoraReview/review_helper.py index 29febcc..57c74e0 100644 --- a/src/FedoraReview/review_helper.py +++ b/src/FedoraReview/review_helper.py @@ -95,11 +95,6 @@ class ReviewHelper(object): else: self.outfile = ReviewDirs.report_path(self.checks.spec.name) with open(self.outfile,"w") as output: - # get upstream sources - rc = self.__download_sources() - if not rc: - self.log.info('Cannot download upstream sources') - sys.exit(1) if Settings.nobuild: self.checks.srpm.is_build = True self.log.info('Running checks and generate report\n')