From 107ffa6510e9e1563170ac173cdda093c05053ab Mon Sep 17 00:00:00 2001 From: Miro HronĨok Date: Jun 08 2023 08:55:28 +0000 Subject: Fix Python Syntax in the Perl plugin Traceback (most recent call last): File ".../src/FedoraReview/review_helper.py", line 236, in run self._do_run(outfile) File ".../src/FedoraReview/review_helper.py", line 226, in _do_run self._do_report(outfile) File ".../src/FedoraReview/review_helper.py", line 99, in _do_report self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile) File ".../src/FedoraReview/review_helper.py", line 108, in _run_checks self.checks = Checks(spec, srpm) ^^^^^^^^^^^^^^^^^^ File ".../src/FedoraReview/checks.py", line 286, in __init__ _ChecksLoader.__init__(self) File ".../src/FedoraReview/checks.py", line 175, in __init__ self._load_checks() File ".../src/FedoraReview/checks.py", line 209, in _load_checks plugins = load("plugins") ^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/straight/plugin/loaders.py", line 169, in unified_load return ModuleLoader(recurse=recurse).load(namespace) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/straight/plugin/loaders.py", line 19, in load self._fill_cache(*args, **kwargs) File "/usr/lib/python3.11/site-packages/straight/plugin/loaders.py", line 116, in _fill_cache self._cache = list(modules) ^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/straight/plugin/loaders.py", line 102, in _findPluginModules module = import_module(import_path) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.11/importlib/__init__.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "", line 1206, in _gcd_import File "", line 1178, in _find_and_load File "", line 1149, in _find_and_load_unlocked File "", line 690, in _load_unlocked File "", line 936, in exec_module File "", line 1074, in get_code File "", line 1004, in source_to_code File "", line 241, in _call_with_frames_removed File ".../src/FedoraReview/plugins/perl.py", line 52 self.FAIL, "Explicit dependency on perl-devel is not allowed unless ^ SyntaxError: unterminated string literal (detected at line 52) --- diff --git a/plugins/perl.py b/plugins/perl.py index 49f9650..742c729 100644 --- a/plugins/perl.py +++ b/plugins/perl.py @@ -49,9 +49,9 @@ class PerlCheckBuildRequires(PerlCheckBase): for br in self.spec.build_requires: if br.startswith("perl-devel"): self.set_passed( - self.FAIL, "Explicit dependency on perl-devel is not allowed unless - building architecture-specific code which links to - libperl.so" + self.FAIL, "Explicit dependency on perl-devel is not allowed unless " + "building architecture-specific code which links to " + "libperl.so" ) return compat = rpm.expandMacro(perl_compat)