Fedora-app

#6 [GSoC] Update Ionic to v3
Merged by a2batic. Opened by amitosh.
amitosh/Fedora-app upgrade-ionic  into  master

Download 6.patch

Closes #4

Update Ionic to v3 and Angular to v5, so that we can build it properly with the latest tools and target newer Android APIs.

  • [x]: Migrate to typescript
  • [x]: Update dependencies
  • [x]: Update stylesheets to match Ionic v3
  • [x]: Update templates to match Angular v5 syntax
  • [x]: Get it built!
  • [x]: Update provider definitions to match v3
  • [x]: Migrate Request provider to use the new simpler HttpClient provider instead of (now removed) Http* classes
  • [x]: Fix angular deprecations
  • [x]: Fix ionic-native incompatibilities
  • [x]: Fix API bugs
  • [x]: Test it with various devices
  • [x]: Fix missing icons
  • [x]: Fix CSS differences with Ionic v3

2 new commits added

  • Get the app up and running under browser and android
  • Fix incompatibilities during module init

3 new commits added

  • Fix lint errors
  • Fix errors in event-handling on browsers
  • Fix type assertsions in social providers

rebased onto ee6f4ef7fda337775bfff6ecf6bbfdf037542405

1 new commit added

  • Fix Chrome z-index bug in header

@a2batic

This PR is ready now! Please review and suggest changes if necessary.

Known issues:
- Splash screen fades too soon
- InAppBrowser has lost all its theming.

Tested against:
- Browser (Firefox 58, Chrome 64)
- Android v7.1.0 (MIUI 9.2)
- Android v4.4.4

@amitosh, PR looks good to me. Few things that has to be done:
1. Either squash your commits to a single commit or add [GSoC] in the front of each.
2. Add [GSoC] in front of your PR message.
3. Add your signed-off commit -s.
4. Once this PR is merged, send a mail to mailing list mentioning details about your first PR to this project.

rebased onto 758e8434796329a96dead259ea35cd3a7d6a556f

@a2batic , Out of curiosity what's the rationale behind the "signed-off"? We already signed the FPCA separately.
Edited by amitosh

@amitosh, its a good practice, since you mentioned about FPCA, I think we can skip it.

Also, please rebase and update your patch.

rebased onto 9ad7ff71e16ac6d3323a0c0fc7f2adee24f91efb

Pull-Request has been merged by a2batic
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.