#270 Lift mail rate limit on Discussions to improve mailing list mode
Closed: resolved 4 years ago by bex. Opened 4 years ago by fweimer.

Per this comment, I should file a Fedora Council ticket to have the daily mail limit lifted. It's currently at 100, and if it is exceeded, subscribers do not receive any further mail. As a result, mailing list mode is simply not reliable.


Metadata Update from @bcotton:
- Issue assigned to bex

4 years ago

This has been fixed and updated in the discussion thread on discourse. The limit is now 1000. I am closing this and continuing larger effort conversation in #271

Metadata Update from @bex:
- Issue close_status updated to: resolved
- Issue status updated to: Closed (was: Open)

4 years ago

Thanks, @bex. Why didn't you set it to 0, disabling the limit?

  def self.reached_max_emails?(user, email_type = nil)
    return false if SiteSetting.max_emails_per_day_per_user == 0 || CRITICAL_EMAIL_TYPES.include?(email_type)

    count = where('created_at > ?', 1.day.ago)
      .where(user_id: user.id)
      .count

    count >= SiteSetting.max_emails_per_day_per_user
  end

@fweimer I debated it. In the end, I decided that the small protection from a mail storm was worth the effort of seeing if anyone actually gets more than 1000 emails/day.

Login to comment on this ticket.

Metadata