#554 Merge this please (dist-git PR created)
Opened 6 years ago by churchyard. Modified a year ago

Badge description (like "You added a co-maintainer to a package. BFF!"):
- You've created a dist-git package Pull Request.

Help the badges team understand what this idea is all about. If this badge is
awarded for certain kinds of activities:

1) What are those activities?
- Creating a Pull Request in http://src.fedoraproject.org/ Pagure.

2) Who is doing them?
- packagers or soon to be packagers

3) Why are they doing them (is this a means to a different end?)
- to propose changes to packages

4) When do they do them (every day? once a year?)
- depend's on them

5) How do they do them (by talking in IRC? by running commands in the console?
by using a web interface?)
- by using a web interface (or API) at http://src.fedoraproject.org/

Lastly, do you have any ideas for artwork concepts?
- panda with a pile of papers in hands (giving gesture)?


Metadata Update from @riecatnor:
- Custom field artwork adjusted to None
- Custom field concept_review_passed adjusted to None
- Issue tagged with: artwork-needed, development

6 years ago

Metadata Update from @riecatnor:
- Custom field artwork adjusted to needed (was: None)

6 years ago

Metadata Update from @maryshak1996:
- Issue assigned to maryshak1996

6 years ago

I'm going to start working on this but I'm not sure what background I should give it? I'm assuming that I want the orange ring but don't know what category it falls into background-wise... any guidance here?

I'd say, commits, pink background.

@churchyard do you know the fedmsg message associated with this one?

@maryshak1996 Thank you! I like the idea in general, but I have tho little things I don't like that much:

  • too much pink. background is good, but maybe the panda may be in different color?
  • the papers in panda's hand look too much 3D while the rest of the badge looks flat. It sticks out.

@sayanchowdhury No, unfortunately we are blocked by https://pagure.io/fedora-infrastructure/issue/6322

@maryshak1996, lookin' good! I have a few suggestions for ya. I agree with @churchyard, there is a lot of pink. I would tone down the pink of the bg to be closer to this: https://pagure.io/Fedora-Badges/issue/553 and also try a different panda color.. not sure what's going to look good. Maybe the fedora blue or the development orange. Also the pandas tummy is looking circular on the left side.. can you add in a leg or make that a little more "natural" looking? As for the 3D aspect, I think that is because you are using drop shadows. If we can avoid using them, let's do that! Please try a version without the drop shadows, and if you think they aren't popping out enough, give some of them more contrast or a darker stroke.

Thanks for your work @maryshak1996, looking forward to seeing the next version :)

@maryshak1996, any progress on the artwork? checking in :) thanks!

Hi @maryshak1996 ! This looks so much better already! Marie and I discussed it at the badges meeting today and have a couple of final touches to add:
- panda could gain some weight, it looks so skinny now ;)
- the papers could use a bit more contrast - make them whiter and outline thinner and darker
And that should be perfect, thank you, @maryshak1996 ! =)

As posted in #553, applies here as well.

BTW Before we push this. Juts a random thought (sorry for not bringing it sooner). Should this be a series instead? This is one things that can happen over and over again. When I proposed this badge idea, PRs were a new thing. Now it seems there are plenty of them. So we could have 1, 10, 50, 250 like with Koji.

+1 to making it a series. @maryshak1996 , lookin' good! We reviewed today in the badges meeting and we have a few very small improvements:
- Make the papers in the bg have full opacity (right now they are transparent)
- Make the stroke on the body of the panda the same as the head
That's all :) once you make those changes, if you want to work on making this a series, that would be great!! Thanks for your work

Closing this ticket due to inactivity during Badges virtual hackfest. Please reopen if their is renewed interest. Thanks!

Metadata Update from @riecatnor:
- Issue close_status updated to: declined
- Issue status updated to: Closed (was: Open)

4 years ago

I'm still interested. Pull Requests on src.fp.o should be encouraged.

Metadata Update from @churchyard:
- Issue status updated to: Open (was: Closed)

4 years ago

Metadata Update from @riecatnor:
- Custom field artwork adjusted to approved (was: needed)
- Issue untagged with: artwork - needed
- Issue tagged with: artwork - approved

4 years ago

Metadata Update from @churchyard:
- Issue tagged with: needs-rules

4 years ago

Issue tagged with: AW: needed

2 years ago

A summary of the design work that needs to be done here:
- Take the design from this this comment and make it into a series of badges with numbers: 1, 5, 10, 25, 50, 100.

Metadata Update from @riecatnor:
- Assignee reset
- Issue untagged with: AW: approved
- Issue tagged with: outreachy-2023

a year ago

Hello @riecatnor and @smeragoel,
I want to contribute to this badge.

Hi folks! Thanks for starting work here, see feedback below

@lydiaogh nice start, I have some notes for you, I think some of them I have written on other tickets so I won't get too detailed on those parts.
- As always, remember to add both the PNG and SVGs to the ticket for review
- Make sure you are not making adjustments to the template, the output should be 256x 256 pixels
- I think the lettering needs to be dark on the outside, mid-tone in the middle, and white for the body
- The orange of the lettering matches the badge ring, but I think its blending into the pink background. Maybe try blue to match the panda? Magenta, pink, and white might work too. This needs some experimentation :)

@duchessolive nice work! Some notes:
- I would give the same feedback to you, the orange of the lettering is blending into the pink background. I'd try blue/light blue/white or magenta/pink/white to start.
- I think the placement of the numbering should stay consistent for all the badges, bottom left looks nice! Though the "100" feels a bit tight in the space there, maybe make it a bit smaller

Looking forward to your next drafts!

Fedm1.pngFedm1.svgFedm5.pngFedm5.svgFedm10.pngFedm10.svgFedm25_p.pngFedm25_p.svgFedm50.pngFedm50.svgFedm100.pngFedm100.svg

Hi @riecatnor @smeragoel I tried out the blue numbering color as earlier suggested

Hi @riecatnor @smeragoel I tried out the blue numbering color as earlier suggested
merge_25.svgmerge_100.pngmerge_blue_1.pngmerge_blue_1.svgmerge_blue_5.pngmerge_blue_5.svgmerge_blue_10.pngmerge_blue_10.svgmerge_blue_25.pngmerge_blue_25.svgmerge_blue_50.pngmerge_blue_50.svgMerge_blue_100.svg

Hi @riecatnor I tried out the magenta and pink color also
merge_magenta_1.pngmerge_magenta_1.svgmerge_magenta_5.pngmerge_magenta_5.svgmerge_magenta_10.svgmerge_magenta_25.pngmerge_magenta_25.svgmerge_magenta_50.pngmerge_magenta_50.svgmerge_magenta_100.pngmerge_magenta_100.svg

Hi folks, thanks for the continued work here! Feedback below :100:

@lydiaogh notes for you:
- I think there might be some issues with the template or exported png. The padding around the badge looks incorrect and the png is 238x238 pixels
- I think the blue numbering looks great! It looks a bit blurry, I think it is because the white part of the number is so small, the blues are overpowering. This badge has a nice example of blue lettering.. look under "Criteria" to find the original ticket and artwork file. You can import that design into your file and grab the numbering to use

@duchessolive nice work here! Notes for you:
- The blue is looking great, let's continue with those designs
- My only feedback is that the dark blue stroke seems off centered to the white/light blue.. Take a look at the badge I suggested in the comment below.. maybe you can use that as well :)

Looking forward to the next drafts!

Hi, @riecatnor Thank you for your feedback, I have effected the corrections

merge_1.pngmerge_1.svgmerge_2.pngmerge_2.svgmerge_3.pngmerge_3.svgmerge_4.pngmerge_4.svgmerge_5.pngmerge_5.svgmerge_6.pngmerge_6.svg

@riecatnor I have aligned the lettering
merg_blue_3.svgmerge_blue_1.pngmerge_blue_2.pngmerge_blue_2.svgmerge_blue_3.pngmerge_blue_4.pngmerge_blue_4.svgmerge_blue_5.pngmerge_blue_5.svgmerge_blue_6.pngmerge_blue_6.svgmerger_blue_1.svg

Hi @duchessolive!

  • In the latest version, you switched to the lighter blue. I think riecatnor mentioned sticking with the dark blue in the previous review so let's stick with that!
  • the text is still not centred properly. The white layer is shifting towards the right at the end.
  • I see that you have tried to align all the texts on the badges. I'd say for the lower digits (1, 5, 10,) you can increase their size to fit the space

Hi @riecatnor @smeragoel I switched back to the dark blue
merge_this_1.pngMerge_this_1.svgmerge_this_2.pngmerge_this_2.svgmerge_this_3.pngmerge_this_3.svgmerge_this_4.pngmerge_this_4.svgmerge_this_5.pngmerge_this_5.svgmerge_this_6.pngmerge_this_6.svg

Login to comment on this ticket.

Metadata
Boards 1
Artwork Status: Done
Attachments 17
Attached 6 years ago View Comment
Attached 6 years ago View Comment
Attached 6 years ago View Comment
Attached 6 years ago View Comment
Attached 6 years ago View Comment
Attached 6 years ago View Comment
Attached 4 years ago View Comment
Attached a year ago View Comment
svg
Attached a year ago View Comment
Attached a year ago View Comment
Attached a year ago View Comment
Attached a year ago View Comment
Attached a year ago View Comment
Attached a year ago View Comment
Attached a year ago View Comment
Attached a year ago View Comment
Attached a year ago View Comment