#552 'Helping Hand' Badge bug
Opened 6 years ago by athoscr. Modified 6 years ago

Not sure if this is already known, so I am opening this here:

I was awarded the helping hand badge [1], which should be awarded when someone builds a package belonging to someone else, when building a package I own.

This happened after I build the first package I requested after the dist-git -> pagure migration

[1] https://badges.fedoraproject.org/badge/helping-hand


Metadata Update from @jflory7:
- Custom field artwork adjusted to None
- Custom field concept_review_passed adjusted to None
- Issue priority set to: Normal
- Issue tagged with: bug

6 years ago

Hey @athoscr,

I was awarded the helping hand badge [1], which should be awarded when someone builds a package belonging to someone else, when building a package I own.

I was taking a look at the rule definition for the badge. See the comment:

The badge is only awarded if the owner of the build is not an owner of the package in the pkgdb.

I'm wondering if this could have been something that broke with pkgdb, since it's now deprecated. This is definitely one that I'd need to defer to someone in Fedora Infrastructure, like @pingou, @puiterwijk, @ralph, or @kevin, with regards to whether the fedmsg query to pkgdb is still valid now that pkgdb has done away.

For relevance:

# From the ticket:
# Trigger from buildsys.build.state.change like all the Koji Success builds,
# then check package builder and owner. Though having a quick look, I'm not
# sure this info is in the fedmsg message itself, I think you get just the
# build submitter; do we need to extend fedmsg-koji for this, or can we check
# the package owner in pkgdb in the trigger/criteria?

trigger:
  all:
  - topic:  buildsys.build.state.change
  - lambda: msg.get('msg', {}).get('new', None) is 1
  - lambda: msg.get('msg', {}).get('instance', None) == 'primary'

# This is the most complex criteria we have to date.  The badge is only awarded
# if the owner of the build is *not* an owner of the package in the pkgdb.

criteria:
  not:
    pkgdb:
      owns:
        user: "%(msg.owner)s"
        packages:
        - "%(msg.name)s"

recipient: "%(msg.owner)s"

I also just received this badge erroneously; here is the message that triggered it if that helps.

Login to comment on this ticket.

Metadata