#306 "Stop That Update!" awarded for update headed to testing
Closed: Pushed None Opened 7 years ago by lmacken.

Problem:

https://badges.fedoraproject.org/badge/stop-that-update!

The badge description says "You submitted negative feedback on an update while on its way to the stable repo", however I was just awarded this badge for giving negative feedback to an update that is on it's way to testing: https://admin.fedoraproject.org/updates/bugwarrior-1.0.1-1.fc21

The rule should probably be fixed, or the badge description get updated.


I guess this happened as there is rule for an update that is in pending state also
- lambda: msg.get('msg', {}).get('comment', {}).get('update_status') == 'pending'

For reference, here's the message the incorrectly awarded the badge: https://apps.fedoraproject.org/datagrepper/id?id=2014-e6332f0f-2d75-4a46-8bfe-d486623b6c93&is_raw=true&size=extra-large

And, here's the rule that awards the badge https://git.fedorahosted.org/cgit/badges.git/tree/rules/stop-that-update.yml

We could probably just add this to the trigger:

{{{
lambda: msg.get('msg', {}).get('comment', {}).get('update_request') == 'stable'
}}}

Replying to [comment:2 ralph]:

We could probably just add this to the trigger:

{{{
lambda: msg.get('msg', {}).get('comment', {}).get('update_request') == 'stable'
}}}

Yeah, I think this'll do it. +1

Login to comment on this ticket.

Metadata