#22 Phoenix Down badge
Closed: Pushed None Opened 5 years ago by adamwill.

Another badge idea: the Phoenix Down badge, for unretiring a package (counterpart to Old Yeller badge, ticket #21). (Phoenix Down reference: http://finalfantasy.wikia.com/wiki/Phoenix_Down ). I'll attach another probably-wrong skeleton yaml file. I am going to keep doing this until someone comes and makes me stop, you realize.


Here are some candidate pixels.

Actual designers: feel free to clean up my mess ;)

Here are some candidate pixels.

Actual designers: feel free to clean up my mess ;)

I dig them! The first one is awesome, but I think a Pheonix Down was just a feather in the referenced game, and not a potion (maybe?). How does a mix of the second two look, with the striped background AND the coloured feather? Just an idea. They definitely all look awesome though! :D

What do you all think?

I dig them! The first one is awesome, but I think a Pheonix Down was just a feather in the referenced game, and not a potion (maybe?). How does a mix of the second two look, with the striped background AND the coloured feather? Just an idea. They definitely all look awesome though! :D

What do you all think?

P.S. Even if we don't use the potion bottle (which we totally can, I'm not opposed), we should use it for another badge, because it is awesome.

P.S. Even if we don't use the potion bottle (which we totally can, I'm not opposed), we should use it for another badge, because it is awesome.

Oooh, that PNG looks good, we could use that. :)

Thoughts?

Oooh, that PNG looks good, we could use that. :)

Thoughts?

the yaml for this one isn't actually complete yet. i'll fix that in a bit. I've added a concept of 'proposed artwork' to the ticket elements, so marking this as proposed.

the yaml for this one isn't actually complete yet. i'll fix that in a bit. I've added a concept of 'proposed artwork' to the ticket elements, so marking this as proposed.

latest version. No Black, matches bottle color.
phoenixdown.2.png

latest version. No Black, matches bottle color.
phoenixdown.2.png

Thanks so much for the artwork! It's awesome. As for the other, can we get the SVG too? Thanks.

As far as the criteria: goes, Ralph says this should be possible - for an unretirement, pkgdb.package.retire should pass 'retirement': 'unretired' in its msg. I guess we need to use a lambda...thingy...to do that? I'm attaching a .yml that I THINK is right, but please check it.

Thanks so much for the artwork! It's awesome. As for the other, can we get the SVG too? Thanks.

As far as the criteria: goes, Ralph says this should be possible - for an unretirement, pkgdb.package.retire should pass 'retirement': 'unretired' in its msg. I guess we need to use a lambda...thingy...to do that? I'm attaching a .yml that I THINK is right, but please check it.

updated yaml file with a line wrapping fix
pkgdb-phoenix-down.yml

updated yaml file with a line wrapping fix
pkgdb-phoenix-down.yml

Set triaged to 'yes' for all tickets, as I've hit them all already.

Set triaged to 'yes' for all tickets, as I've hit them all already.

just put types back in, we'll try and handle bugs here too, no new trac.

just put types back in, we'll try and handle bugs here too, no new trac.

Love the design!

Would you be able to upload the SVG? I think the sizing and the whitespace around the badge is a little off.

the svg here:
https://fedorahosted.org/fedora-badges/ticket/24
has the correct positioning and sizing of the badge in the white background area.

Love the design!

Would you be able to upload the SVG? I think the sizing and the whitespace around the badge is a little off.

the svg here:
https://fedorahosted.org/fedora-badges/ticket/24
has the correct positioning and sizing of the badge in the white background area.

So, the yaml for this one has the same issue as #21 had. msg.package_listing.owner should instead be msg.agent.

So, the yaml for this one has the same issue as #21 had. msg.package_listing.owner should instead be msg.agent.

Indeed. Had to go back a long way to find an unretirement message to check, guess this will be a hard badge to earn :)

Indeed. Had to go back a long way to find an unretirement message to check, guess this will be a hard badge to earn :)

updated yaml which awards the badge to the right person and not 'orphan', thanks threebean for the catch
pkgdb-phoenix-down.2.yml

updated yaml which awards the badge to the right person and not 'orphan', thanks threebean for the catch
pkgdb-phoenix-down.2.yml

Here's decause's svg - https://raw.github.com/FOSSRIT/badges/master/art/src/fedora/phoenixdown.svg

Can someone from the design-team use it to fix the pngs?

Here's decause's svg - https://raw.github.com/FOSSRIT/badges/master/art/src/fedora/phoenixdown.svg

Can someone from the design-team use it to fix the pngs?

[[Image(phoenix-down.png)]]

[[Image(phoenix-down.png)]]

phoenix-down with proper padding
phoenix-down.png

phoenix-down with proper padding
phoenix-down.png

Should this badge already work? I had just unretired "gpx-viewer" but I didn't received the it so far. ;-) It was also never awarded to anybody else...

Should this badge already work? I had just unretired "gpx-viewer" but I didn't received the it so far. ;-) It was also never awarded to anybody else...

Yes, I think it was broken. I haven't verified yet, but I think this commit will have fixed the issue: https://git.fedorahosted.org/cgit/badges.git/commit/?id=cfe9c390982dac9132cbda14a3197ddc66d549a6

Yes, I think it was broken. I haven't verified yet, but I think this commit will have fixed the issue: https://git.fedorahosted.org/cgit/badges.git/commit/?id=cfe9c390982dac9132cbda14a3197ddc66d549a6

Replying to [comment:24 ralph]:

Yes, I think it was broken. I haven't verified yet, but I think this commit will have fixed the issue: https://git.fedorahosted.org/cgit/badges.git/commit/?id=cfe9c390982dac9132cbda14a3197ddc66d549a6
I'm wondering if this badge may be broken again. I noticed someone that recently unretired a package did not receive the badge, but I wasn't sure where to poke around in to verify whether the fedmsg trigger was being hit.

Replying to [comment:24 ralph]:

Yes, I think it was broken. I haven't verified yet, but I think this commit will have fixed the issue: https://git.fedorahosted.org/cgit/badges.git/commit/?id=cfe9c390982dac9132cbda14a3197ddc66d549a6
I'm wondering if this badge may be broken again. I noticed someone that recently unretired a package did not receive the badge, but I wasn't sure where to poke around in to verify whether the fedmsg trigger was being hit.

Metadata Update from @adamwill:
- Issue assigned to decause

2 years ago

Login to comment on this ticket.

Metadata
Attachments 12
Attached 5 years ago View Comment
Attached 5 years ago View Comment
Attached 5 years ago View Comment
Attached 5 years ago View Comment
Attached 5 years ago View Comment
Attached 5 years ago View Comment
Attached 5 years ago View Comment
Attached 5 years ago View Comment
Attached 5 years ago View Comment
Attached 5 years ago View Comment
Attached 5 years ago View Comment
Attached 5 years ago View Comment