#51251 Issue 51228 - Fix lock/unlock wording and lib389 use of methods
Closed 2 years ago by spichugi. Opened 2 years ago by spichugi.
spichugi/389-ds-base i51228  into  master

@@ -96,7 +96,7 @@ 

  

  

  def lock(inst, basedn, log, args):

-     dn = _get_dn_arg(args.dn, msg="Enter dn to check")

+     dn = _get_dn_arg(args.dn, msg="Enter dn to lock")

      accounts = Accounts(inst, basedn)

      acct = accounts.get(dn=dn)

      acct.lock()
@@ -104,7 +104,7 @@ 

  

  

  def unlock(inst, basedn, log, args):

-     dn = _get_dn_arg(args.dn, msg="Enter dn to check")

+     dn = _get_dn_arg(args.dn, msg="Enter dn to unlock")

      accounts = Accounts(inst, basedn)

      acct = accounts.get(dn=dn)

      acct.unlock()

@@ -105,7 +105,9 @@ 

              spec_attr = self._dict_get_with_ignore_indexerror(config_settings, "specattrname")

              limit_attr = self._dict_get_with_ignore_indexerror(config_settings, "limitattrname")

  

-             cos_entries = CosTemplates(inst, self.dn)

+             mapping_trees = MappingTrees(inst)

+             root_suffix = mapping_trees.get_root_suffix_by_entry(self.dn)

+             cos_entries = CosTemplates(inst, root_suffix)

              accpol_entry_dn = ""

              for cos in cos_entries.list():

                  if cos.present(spec_attr):

file modified
+1 -1
@@ -1881,7 +1881,7 @@ 

      """

  

      def __init__(self, instance, dn=None):

-         super(AccountPolicyConfig, self).__init__(instance, dn)

+         super(AccountPolicyEntry, self).__init__(instance, dn)

          self._rdn_attribute = 'cn'

          self._must_attributes = ['cn']

          self._create_objectclasses = ['top', 'accountpolicy']

Descriptions: Clean up lib389 idm-account methods to presicely locate
CoS objects. Also, fix AccountPolicyEntry super() function.
Fix wording in user input requests while doing lock/unlock.

https://pagure.io/389-ds-base/issue/51228

Reviewed by: ?

rebased onto 52a09ce

2 years ago

Pull-Request has been merged by spichugi

2 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4304

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

2 years ago