#51250 Ticket 51177 - fix warnings
Closed 2 years ago by spichugi. Opened 2 years ago by firstyear.
firstyear/389-ds-base 51177-warnings  into  master

@@ -1464,6 +1464,9 @@ 

  void slapi_pblock_set_flag_operation_notes(Slapi_PBlock *pb, uint32_t opflag);

  void slapi_pblock_set_result_text_if_empty(Slapi_PBlock *pb, char *text);



+ int slapi_exists_or_add_internal(Slapi_DN *dn, const char *filter, const char *entry, const char *modifier_name);


  #ifdef __cplusplus



file modified
+1 -1
@@ -34,7 +34,7 @@ 

      int result = slapi_exists_or_add_internal(base_sdn, filter, dupentry, modifier_name);


      if (result != 0) {

-         slapi_log_error(SLAPI_LOG_FATAL, upgrade_id, "Failed to create entry: %"PRId32": %s\n", result);

+         slapi_log_error(SLAPI_LOG_FATAL, upgrade_id, "Failed to create entry: %"PRId32"\n", result);

          uresult = UPGRADE_FAILURE;



Bug Description: Humans make mistakes. A lot of mistakes. In
the commit of 51177 I made a mistake of not checking every
compiler warning, which led to a mistake that could cause
problems for others.

Fix Description: There is no fix for humans. But we can
fix the compiler warnings.

fixes #51177

Author: William Brown william@blackhats.net.au

Review by: ???

Note the warning about the unused function will remain until a non-rust use of this feature exists because I don't want to mess up the ifdefs.

rebased onto 3d61aaf

2 years ago

Pull-Request has been merged by firstyear

2 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4303

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

2 years ago