389-ds-base

Clone
Source Code
GIT

#51234 Issue 51233 - ds-replcheck crashes in offline mode
Closed 4 years ago by spichugi. Opened 4 years ago by mreynolds.
mreynolds/389-ds-base issue51233  into  master

file modified
+4 
@@ -725,6 +725,10 @@ 
 

      missing = False
 

      for dn in master_dns:
 

          mresult = ldif_search(MLDIF, dn)
 

+         if mresult['entry'] is None and mresult['conflict'] is None and not mresult['tombstone']:
 

+             # Try from the beginning
 

+             MLDIF.seek(0)
 

+             mresult = ldif_search(MLDIF, dn)
 

          rresult = ldif_search(RLDIF, dn)
 

  

          if dn in replica_dns:

Bug Description:

When processing all the DN's found in the Master LDIF it is possible that the LDIF is not in the expected order and ldifsearch fails (crashing the tool).

Fix Description:

If ldifsearch does not find an entry, start from the beginning of the LDIF and try again.

relates: https://pagure.io/389-ds-base/issue/51233

LGTM! Ack

rebased onto ea39a99
4 years ago

Pull-Request has been merged by mreynolds
4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4287

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
4 years ago
Metadata
None
No Tags
Changes Summary 1
+4 -0
file changed
ldap/admin/src/scripts/ds-replcheck
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.