389-ds-base

#51232 Issue 50260 - Fix test according to #51222 fix
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base i50260  into  master

Download 51232.patch

Description: Managed Entry plugin behaviour was fixed and
returned codes were cleaned up. Now we allow to continue
modrdn and delete managing entry operations execution
even when managed entry doesn't exists.
Also allow 'cn=directory manager' to delete managed entry
on direct update.

https://pagure.io/389-ds-base/issue/50260
https://pagure.io/389-ds-base/issue/51222

Reviewed by: ?

LGTM

LGTM

Actually, I'm not sure about this. It looks like the behavior of MEP was changed. In this test, what were failures and now expected to pass. So it is probably not testing entry cache corruption :-( I thought your fix was to reject deletes of MEP entries, but in this test now expects failures to be successes - that does not make sense to me. In order to test the entry cache corruption you need updates to fail, then you need to make sure that the updates done by the be txn plugins (before the failure) are not present in the cache. Since the operations are passing I don't think you are testing this correctly. I need to look at this closer I guess...

1 new commit added

  • Make the managing entry removal fail

2 new commits added

  • Make the managing entry removal fail
  • Issue 50260 - Fix test according to #51222 fix

LGTM

Actually, I'm not sure about this. It looks like the behavior of MEP was changed. In this test, what were failures and now expected to pass. So it is probably not testing entry cache corruption :-( I thought your fix was to reject deletes of MEP entries, but in this test now expects failures to be successes - that does not make sense to me. In order to test the entry cache corruption you need updates to fail, then you need to make sure that the updates done by the be txn plugins (before the failure) are not present in the cache. Since the operations are passing I don't think you are testing this correctly. I need to look at this closer I guess...

Right... I've changed the way it fails.
Will it work?

LGTM!

rebased onto 066a7b49df9c9addfa97e115f483a4f7d5f37c02

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4285

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.