#51217 Issue 49481 - remove unused or unnecessary database plugin functions
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue49481  into  master

Download 51217.patch

Description:

Removed some unused database plugin initializations. Also cleaned up some of the logging in the bdb specific code that was not using the correct function name.

Fixes: https://pagure.io/389-ds-base/issue/49481

SLAPI_PLUGIN_DB_INIT_INSTANCE_FN is used nowhere, in chaning backend it is only used in a comment.
SLAPI_PLUGIN_DB_SIZE_FN is set in cb and always returns 0, can't see where it is used. If we remove the function for main backend, we will not need it for cb. So I think all the references to these could be removed, from slapi-private, cb, pblock

SLAPI_PLUGIN_DB_INIT_INSTANCE_FN is used nowhere, in chaning backend it is only used in a comment.
SLAPI_PLUGIN_DB_SIZE_FN is set in cb and always returns 0, can't see where it is used. If we remove the function for main backend, we will not need it for cb. So I think all the references to these could be removed, from slapi-private, cb, pblock

Hi Ludwig!

Yeah when I was working on the other cleanup ticket I realized there was more to do in this one. I will continue to work on it...

rebased onto f0f0c92e7f50014db72de679550e6b940f7f70e8

I'm going to assume entryusn is already in the schema?

I'd still want to @tbordaz or @elkris to have a look as well, but I don't see anything obviously wrong (but I may have missed something too, backend code is not something I'm a complete expert in)

I'm going to assume entryusn is already in the schema?

It is, it's in 01core389.ldif

Nice cleanup. The patch looks good to me. Ack

rebased onto 2b6e9cf4f9724a8d2bedda75fa54b7c8717318de

rebased onto 98d6c7f8afd4dd8cc802c3b3c7e6bb133c8c09c9

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4270

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata