389-ds-base

#51216 Issue 51129 - SSL alert: The value of sslVersionMax "TLS1.3" is higher than the supported version
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue51129  into  master

Download 51216.patch

Bug Description:

If you try and set the sslVersionMax higher than the default range, but within the supported range, you would still get an error and the server would reset the max to "default" max value.

Fix Description:

Keep track of both the supported and default SSL ranges, and correctly use each range for value validation. If the value is outside the supported range, then use default value, etc, but do not check the requested range against the default range. We only use the default range if there is no specified min or max in the config, or if a invalid min or max value is set in the config.

Also, refactored the range variable names to be more accurate:

  • enabledNSSVersions --> defaultNSSVersions
  • emin, emax --> dmin, dmax

Also fixed a warning in lib389 about deprecated regex expression.

relates: https://pagure.io/389-ds-base/issue/51129

Famous last words.

Just confirming that in this case, we default to the supportedNSSVersion.min instead of our DEFAULT_SSL_VERSION?

Otherwise reading it a few times, I have no issues with this :)

rebased onto 41bf43f2225adbc70730ce3d387711567de8bcc5

Just confirming that in this case, we default to the supportedNSSVersion.min instead of our DEFAULT_SSL_VERSION?

Ahh, thanks for bringing this up. This code is somewhat invalid when dealing with TLS1.0. We no longer need CURRENT_DEFAULT_SSL_VERSION, but we are still using DEFVERSION to force a default minimum of TLS1.2 if the user did not specify a TLS minimum.

Please review one last time...

Ahhh yep. Okay, no problems from me :) ack.

rebased onto 78e3fb4a748465498786e27fcd02b7231acc4241

rebased onto 2c8e3398522670a53389d7591b333d74a620d655

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4269

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.