PR#51210: Issue 51136 - JSON Error output has redundant messages -

389-ds-base

#51210 Issue 51136 - JSON Error output has redundant messages

Closed Sep 13, 2020 by spichugi. Opened Jul 21, 2020 by spichugi.

spichugi/389-ds-base i51136 into master

spichugi commented Jul 21, 2020

Bug Description: When we try to start an instance for which
'systemctl start' command has failed, it produces excessive
output which is not a clear JSON.

Fix Description: Redirect stderr to stdout as we don't need
the info in CLI. User needs to check logs if something went wrong.
Also, add a new-line character in the end of DS CLI tool's stderr.

https://pagure.io/389-ds-base/issue/51136

Reviewed by: ?

mreynolds commented Jul 21, 2020

I'm worried that you adding a newline might break the UI when it tries to parse the JSON object. Did you check if the UI correctly reports the errors now? If does work in the UI then you get my ack.

rebased onto 632a8e085287ed75361f3b168ec81ec2f5470497

Jul 23, 2020

spichugi commented Jul 23, 2020

I'm worried that you adding a newline might break the UI when it tries to parse the JSON object. Did you check if the UI correctly reports the errors now? If does work in the UI then you get my ack.

It works fine.

I've also fixed the issue that was printing a lot of messages (or crashing) when we switch to another instance that was not online.

Please, review the React code cleanup.

mreynolds commented Jul 23, 2020

Tested and approved, ack!

Pull-Request has been merged by spichugi

Jul 23, 2020

spichugi commented Sep 13, 2020

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4263

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Sep 13, 2020

Metadata

Assignee

None

Tags

No Tags

389-ds-base

#51210 Issue 51136 - JSON Error output has redundant messages Closed Sep 13, 2020 by spichugi. Opened Jul 21, 2020 by spichugi. spichugi/389-ds-base i51136 into master

Metadata

#51210 Issue 51136 - JSON Error output has redundant messages

Closed Sep 13, 2020 by spichugi. Opened Jul 21, 2020 by spichugi.

spichugi/389-ds-base i51136 into master