389-ds-base

Clone
Source Code
GIT

#51207 Issue 51059 - If dbhome directory is set online backup fails
Closed 3 years ago by spichugi. Opened 3 years ago by spichugi.
spichugi/389-ds-base i51059  into  master

file modified
+5 
@@ -427,6 +427,11 @@ 
 

  

      /* tell it to archive */
 

      return_value = dblayer_backup(li, directory, task);
 

+     if (return_value) {
 

+         slapi_log_err(SLAPI_LOG_BACKLDBM,
 

+                       "ldbm_back_ldbm2archive", "dblayer_backup failed (%d).\n", return_value);
 

+         goto err;
 

+     }
 

  

      return_value = plugin_call_plugins(pb, SLAPI_PLUGIN_BE_POST_BACKUP_FN);
 

      if (return_value) {

Bug Description: If the dbhome directory is set, eg to /dev/shm/instance
then an online backup fails because it looks for the log.000000x file
in the wring diretcory.
This is hidden because the return code is overwritten before checking.

Fix Description: If dblayer_backup function fails - go to error processing
section.

https://pagure.io/389-ds-base/issue/51059

Reviewed by: ?

LGTM

rebased onto 22c5149
3 years ago

Pull-Request has been merged by spichugi
3 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4260

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
3 years ago
Metadata
None
No Tags
Changes Summary 1
+5 -0
file changed
ldap/servers/slapd/back-ldbm/archive.c
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.