#51203 Issue 50791 - Healthcheck to find notes=F
Closed 2 years ago by spichugi. Opened 2 years ago by bsmejkal.
bsmejkal/389-ds-base access_notes_healthcheck  into  master

@@ -13,6 +13,8 @@ 

  

  from lib389.backend import Backends

  from lib389.cos import CosTemplates, CosPointerDefinitions

+ from lib389.dbgen import dbgen_users

+ from lib389.idm.account import Accounts

  from lib389.index import Index

  from lib389.plugins import ReferentialIntegrityPlugin

  from lib389.utils import *
@@ -71,6 +73,21 @@ 

      topology.logcap.flush()

  

  

+ @pytest.fixture(scope="function")

+ def setup_ldif(topology_st, request):

+     log.info("Generating LDIF...")

+     ldif_dir = topology_st.standalone.get_ldif_dir()

+     global import_ldif

+     import_ldif = ldif_dir + '/basic_import.ldif'

+     dbgen_users(topology_st.standalone, 5000, import_ldif, DEFAULT_SUFFIX)

+ 

+     def fin():

+         log.info('Delete file')

+         os.remove(import_ldif)

+ 

+     request.addfinalizer(fin)

+ 

+ 

  @pytest.mark.ds50873

  @pytest.mark.bz1685160

  @pytest.mark.xfail(ds_is_older("1.4.1"), reason="Not implemented")
@@ -320,6 +337,104 @@ 

      os.remove(file)

  

  

+ @pytest.mark.ds50791

+ @pytest.mark.bz1843567

+ @pytest.mark.xfail(ds_is_older("1.4.3.8"), reason="Not implemented")

+ def test_healthcheck_notes_unindexed_search(topology_st, setup_ldif):

+     """Check if HealthCheck returns DSLOGNOTES0001 code

+ 

+     :id: b25f7027-d43f-4ec2-ac49-9c9bb285df1d

+     :setup: Standalone instance

+     :steps:

+         1. Create DS instance

+         2. Set nsslapd-accesslog-logbuffering to off

+         3. Import users from created ldif file

+         4. Use HealthCheck without --json option

+         5. Use HealthCheck with --json option

+     :expectedresults:

+         1. Success

+         2. Success

+         3. Success

+         4. Healthcheck reports DSLOGNOTES0001

+         5. Healthcheck reports DSLOGNOTES0001

+     """

+ 

+     RET_CODE = 'DSLOGNOTES0001'

+ 

+     standalone = topology_st.standalone

+ 

+     log.info('Delete the previous access logs')

+     topology_st.standalone.deleteAccessLogs()

+ 

+     log.info('Set nsslapd-accesslog-logbuffering to off')

+     standalone.config.set("nsslapd-accesslog-logbuffering", "off")

+ 

+     log.info('Stopping the server and running offline import...')

+     standalone.stop()

+     assert standalone.ldif2db(bename=DEFAULT_BENAME, suffixes=[DEFAULT_SUFFIX], encrypt=None, excludeSuffixes=None,

+                               import_file=import_ldif)

+     standalone.start()

+ 

+     log.info('Use filters to reproduce "notes=A" in access log')

+     accounts = Accounts(standalone, DEFAULT_SUFFIX)

+     accounts.filter('(uid=test*)')

+ 

+     log.info('Check that access log contains "notes=A"')

+     assert standalone.ds_access_log.match(r'.*notes=A.*')

+ 

+     run_healthcheck_and_flush_log(topology_st, standalone, RET_CODE, json=False)

+     run_healthcheck_and_flush_log(topology_st, standalone, RET_CODE, json=True)

+ 

+ 

+ @pytest.mark.ds50791

+ @pytest.mark.bz1843567

+ @pytest.mark.xfail(ds_is_older("1.4.3.8"), reason="Not implemented")

+ def test_healthcheck_notes_unknown_attribute(topology_st, setup_ldif):

+     """Check if HealthCheck returns DSLOGNOTES0002 code

+ 

+     :id: 71ccd1d7-3c71-416b-9d2a-27f9f6633101

+     :setup: Standalone instance

+     :steps:

+         1. Create DS instance

+         2. Set nsslapd-accesslog-logbuffering to off

+         3. Import users from created ldif file

+         4. Use HealthCheck without --json option

+         5. Use HealthCheck with --json option

+     :expectedresults:

+         1. Success

+         2. Success

+         3. Success

+         4. Healthcheck reports DSLOGNOTES0002

+         5. Healthcheck reports DSLOGNOTES0002

+     """

+ 

+     RET_CODE = 'DSLOGNOTES0002'

+ 

+     standalone = topology_st.standalone

+ 

+     log.info('Delete the previous access logs')

+     topology_st.standalone.deleteAccessLogs()

+ 

+     log.info('Set nsslapd-accesslog-logbuffering to off')

+     standalone.config.set("nsslapd-accesslog-logbuffering", "off")

+ 

+     log.info('Stopping the server and running offline import...')

+     standalone.stop()

+     assert standalone.ldif2db(bename=DEFAULT_BENAME, suffixes=[DEFAULT_SUFFIX], encrypt=None, excludeSuffixes=None,

+                               import_file=import_ldif)

+     standalone.start()

+ 

+     log.info('Use filters to reproduce "notes=F" in access log')

+     accounts = Accounts(standalone, DEFAULT_SUFFIX)

+     accounts.filter('(unknown=test)')

+ 

+     log.info('Check that access log contains "notes=F"')

+     assert standalone.ds_access_log.match(r'.*notes=F.*')

+ 

+     run_healthcheck_and_flush_log(topology_st, standalone, RET_CODE, json=False)

+     run_healthcheck_and_flush_log(topology_st, standalone, RET_CODE, json=True)

+ 

+ 

  if __name__ == '__main__':

      # Run isolated

      # -s for DEBUG mode

Description:
Created tests, that reproduce notes=A and notes=F in access log
and then check if healthcheck returned proper error code.

Relates: https://pagure.io/389-ds-base/issue/50791

Reviewed by: ???

rebased onto c0688a0

2 years ago

@spichugi
Thanks!
I put you in the commit message and rebased, can you please merge it?

Pull-Request has been merged by spichugi

2 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4256

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

2 years ago
Metadata