389-ds-base

#51170 Issue 51169 - UI - attr uniqueness - selecting empty subtree crashes cockpit
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base ui_fixes  into  master

Download 51170.patch

Description:

The JS code was still using an outdated format for typeAheadvalues that treated the value as an Object with keys, when it was just an array of values.

relates: https://pagure.io/389-ds-base/issue/51169

When I try to edit the existing attributeUniqueness config, I get an error because the this.state.subtrees has a wrong value (item 15):

0: "dsconf"
1: "-j"
2: "ldapi://%2fvar%2frun%2fslapd-localhost.socket"
3: "plugin"
4: "attr-uniq"
5: "set"
6: "attribute uniqueness"
7: "--enabled"
8: "off"
9: "--across-all-subtrees"
10: "off"
11: "--attr-name"
12: "uid"
13: "--subtree"
14: "dc=example,dc=com"
15: {customOption: true, id: "new-id-14", label: "o=redat"}
16: "--top-entry-oc"
17: "account"
18: "--subtree-entries-oc"
19: "accountpolicy"

rebased onto 316c55d20c2d1c0bec4776e7b4534832067ea96f

rebased onto ec7f142e5c56b07956c204425242a8509312428d

@spichugi all fixed, please review...

rebased onto 1f2b4ba11fb8985ad56e32d96a2843d7d2375a3a

It fails for me on a fresh instance (where attributeUniqueness has a config already):

  1. Install a fresh instance with a suffix;
  2. Go to Plugins tab -> Attribute Uniqueness plugin -> Edit the existing config;
  3. See that we already have 'dc=example,dc=con' subtree there (this.state.subtrees == ['dc=example,dc=com']);
  4. Add one more subtree to the field;

When we click on Add in the typeahead field - the browser crashes.

1 new commit added

  • Improve handling of typeAhead values.

Everything should be fixed now...

LGTM! Ack

rebased onto a99cd7c7f4571bb9948f58ae1bb8e84285d0b5df

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4223

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.