#51164 Issue 50545 - Port remaining legacy tools to new python CLI
Closed by spichugi. Opened by bsmejkal.
bsmejkal/389-ds-base legacy_tools  into  master

Download 51164.patch

Description:
Created sanity tests for repl-monitor, dbverify, ldifgen (dbgen) and fixup task
into separate files for each tool.
All tests check output syntax to make sure the tool did not fail with error.
Tests for dbgen create ldif files, that are imported to database and
then check if entries are imported correctly.

Relates: https://pagure.io/389-ds-base/issue/50545

Reviewed by: ???

Great test suite!
I have one small concern only... Could we put the file to the fixture's finalizer so it is removed when we are done with the tests?

And in the other files too.

rebased onto 98a8287e4fa1c2dd8cc1f4712b13440346464a5f

@spichugi
Thanks :)
I moved the files to fixture, so they are deleted when test ends.
Please review.

LGTM! Ack!

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4217

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata