Description:
Add checks for notes=A (fully unindexed search) and notes=F (Unknown attribute in search filter) in the current access log.
relates: https://pagure.io/389-ds-base/issue/50791
Looks good! Do we have a report for notes=U as well?
Ack as it currently is, or happy to re-review if we add notes=U :)
Thanks!
Looks good! Do we have a report for notes=U as well? Ack as it currently is, or happy to re-review if we add notes=U :) Thanks!
Well I left notes=U out on purpose. It's not nearly as severe as a notes=A, and we see notes=U all the time where it's not a problem. I don't want to create a lot of false positives, or have a noisy report when it's not really needed.
I've noticed that we can get notes=U on searches that should be notes=A but Ithink that could be the fact we wrap every search in a (! tombstone) and that component is indexed which gives us the partial warning.
But that's seperate issue I think ...
I think we could have a notes=U, but perhaps it should be a "info" rather than a error or warning. We should be highlighting notes=U when it arises I think ....
Lets address/discuss notes=U in a different ticket (which I will open)...
I'm going to merge what we have so far.
rebased onto f75fd1aaa671c9300cb76f005cdb814ec563e4f2
Pull-Request has been merged by mreynolds
Sounds good mate, thanks!
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/4203
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Description:
Add checks for notes=A (fully unindexed search) and notes=F (Unknown attribute in search filter) in the current access log.
relates: https://pagure.io/389-ds-base/issue/50791