#51148 Issue 50984 - Memory leaks in disk monitoring
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base i50984  into  master

Download 51148.patch

Description: Fix the rest of the leaks in disk monitoring
which are present when we shutdown while being below half
of the threshold (at the start-up in main.c).

Free directories, sockets and ports before going to cleanup.

https://pagure.io/389-ds-base/issue/50984

Reviewed by: ?

Looks reasonable to me. But I'd prefer someone else to have a look as well.

Any reason you moved this block few lines above where it was ?

Any reason you moved this block few lines above where it was ?

I just wanted to do it a bit earlier - before global_backend_lock_init() and write_start_pid_file() calls.
If you think that it is too much of a precaution - I can revert the part.

No I think it is a good idea. I was just curious. ACK

rebased onto 327147cf7b5c6dbfbfae107e823d24183363e418

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4201

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata