#51137 Issue 50781 - Make building cockpit plugin optional
Closed by spichugi. Opened by vashirov.
vashirov/389-ds-base ds50781  into  master

Download 51137.patch

Bug Description:
Currently building 389-ds involves building cockpit-389-ds too,
which is not always desired.

Fix Description:
Introduce a new configure parameter --enable-cockpit, which is on by default.

Fixes: https://pagure.io/389-ds-base/issue/50781

Doc impact: no

Reviewed by: ???

rebased onto ac54e069ceb2d928805d877659aa0b4e7b10da88

This should be 1 by default

This should be 1 by default

Sorry, it's fine. Ack!

Thanks! I had been meaning to maek something like this for a while since I don't test/use cockpit and we don't ship it on suse. Should make my test cycles faster, thank you!

Merging because I want this now darn it!

This should be 1 by default

Sorry, it's fine. Ack!

@mreynolds, you were right, It really should be 1 by default, I committed with 0 by accident. As we agreed in the meeting, I will fix it.

@firstyear, thanks for merging, but you were too fast :) The default in rpm.mk should be 1. Hope it's not too much of overhead to disable it in your workflow.

Not too much work at all. :)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4190

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata