Should it fail or just skip ?

The logic of the patch looks good to me but preferably wait for ACK from a python expert.

It should skip

This won't work in containers.

 I0> systemctl show -p PrivateTmp
System has not been booted with systemd as init system (PID 1). Can't operate.
Failed to connect to bus: Host is down

You probably need to also skip this test if running on with_systemd is false.

why not use check output or similar instead? Popen makes this much more complex ....

Don't call system ls, use os.path.exists() from python natively.

I think there is a fair bit to make this pythonic still, but the idea behind the test is there.

@firstyear @tbordaz
Thanks for your suggestions.
I haven't realized that subprocess.check_output() and os.path.exists() is cleaner approach.
I modified the test, please review.

It's all good, through review we all can learn and teach each other. I hope I wasn't too short/harsh! I will review this early next week if that's okay (It's now out of work hours for me )

No worries :)

That looks much better, thank you!!!

Ack from me, @vashirov did you want to check ?

Just a nitpick: this will run in a container if it has systemd in it :) I do this all the time. A better message would be "Will not run without systemd".
The rest LGTM, thanks!

@vashirov
Thanks, I changed the message :)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4178

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.