#51107 Issue: 51070 - Port Import TET module to python3 part2
Closed by spichugi. Opened by aborah.
aborah/389-ds-base import2  into  master

Download 51107.patch

Bug Description: Port Import TET module to python3 part2

Fixes: https://pagure.io/389-ds-base/issue/51070

Author: aborah

Reviewed by: ???

rebased onto ba024953ea16e37c6c5f24784f882d63335da040

rebased onto d2fb1e1162bd79b101140be4005f7f3e2c12f1a7

rebased onto f0e62d6e3ed946bd831dcd2a42b34f917d3be01e

rebased onto daabe431a8ee7d3b47d8c3011d934ef37d5fc60e

Instead of silent exception we can use a check if a file exists. And if it is there, then delete it.

For a better readability let's use multiline instead of hardcoding new line symbols.

Please put this on the same line at the start of the docstring

Perhaps this should be a fixture? If the test fails in the middle, it will leave the instance with this setting on for the following tests.

rebased onto e44c1d454646743b5cc768e70af7e9dd9dc2daae

rebased onto b7e76dcf408a821d81d5ac5895cadf77bba173ab

Instead of silent exception we can use a check if a file exists. And if it is there, then delete it.

Done

For a better readability let's use multiline instead of hardcoding new line symbols.

Done

Please put this on the same line at the start of the docstring

Done

Perhaps this should be a fixture? If the test fails in the middle, it will leave the instance with this setting on for the following tests.

Done

Instead of silent exception we can use a check if a file exists. And if it is there, then delete it.

Done

I meant something like this:

if os.path.exists(import_ldif):
    os.remove(import_ldif)

Typo in "bogus" here and below in the file name.

Please use triple quotes for the multiline here.

Please use more descriptive name for this fixture, for example toggle_private_import_mem.

rebased onto 52879f7342a31cca26c1eed0b81d9972a6daa377

rebased onto 7cad81162fe9c65a6e9221dc21187be16da4bfdc

rebased onto 322fb6e551959ffbfcd70bb053c2fb0d95089e35

Instead of silent exception we can use a check if a file exists. And if it is there, then delete it.

Done

I meant something like this:
if os.path.exists(import_ldif):
os.remove(import_ldif)

Done

Typo in "bogus" here and below in the file name.

Done

Please use triple quotes for the multiline here.

Done

Please use more descriptive name for this fixture, for example toggle_private_import_mem.

Done

rebased onto bf843907ca33b3bcca517a1d30d74733f1f3b8db

rebased onto 0a71c3db0f5a6a09f0dd3d736cd173aefe582613

Pull-Request has been merged by vashirov

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4160

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata