Bug Description:
When doing an online check with replicas that are very far apart the connection can time out as the hardcoded timeout is 5 seconds.
Fix Description:
Change the default timeout to never timeout, and add an CLI option to specify a specific timeout.
Also caught all the possible LDAP exceptions so we can cleanly "fail". Fixed some python syntax issues, and improved the entry inconsistency report
relates: https://pagure.io/389-ds-base/issue/51102
Looks reasonable to me. Ack,
We, probably, need to add the argument to state_parser also because get_state also calls init_online_params(args)
state_parser
get_state
init_online_params(args)
rebased onto c350ddc99c1618f32ee29db506b007f85f771186
Nice catch! Done, merging...
Pull-Request has been merged by mreynolds
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/4156
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Bug Description:
When doing an online check with replicas that are very far apart the connection can time out as the hardcoded timeout is 5 seconds.
Fix Description:
Change the default timeout to never timeout, and add an CLI option to specify a specific timeout.
Also caught all the possible LDAP exceptions so we can cleanly "fail". Fixed some python syntax issues, and improved the entry inconsistency report
relates: https://pagure.io/389-ds-base/issue/51102