389-ds-base

#51099 Issue 49850 -ldbm_get_nonleaf_ids() painfully slow for databases with many non-leaf entries
Closed by spichugi. Opened by sgouvern.
sgouvern/389-ds-base slow_import  into  master

Download 51099.patch

Description:
With a very large database, gathering non-leaf IDs for creating the ancestorid index took an enormous amount of time.
This test is to verify the fix for this problem.

https://pagure.io/389-ds-base/issue/49850

Author: sgouvern

Reviewed by: firstyear, spichugi

I don't see anything wrong with this test. @vashirov or @spichugi ?

small indentation issue

I think there is no reason to mention BZ number in the commit message.
It is already mentioned in the pagure issue and as a pytest mark.

The rest looks good to me.

rebased onto bed349d7463150ba7febf62365f70cdcfd44e09f

rebased onto 9d5fe06e36c6bf7d2e6854b8f9c703a1779b81c2

Thanks @firstyear and @spichugi for your review.
I fixed the indentation and commit message issues.
@vashirov, I also changed the pytest marker from skipif to xfail, can you please review ?

LGTM! Ack

@spichugi Worth remembering that not everyone has commit rights, so when you ack sometimes you have to do the merge yourself :)

Pull-Request has been merged by firstyear

Thanks for the go and for the merge :)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4152

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.