#51081 Issue:51070 - Port Import TET module to python3 part1
Closed by spichugi. Opened by aborah.
aborah/389-ds-base import1  into  master

Download 51081.patch

Bug Description: Port Import TET module to python3 part1

Relates: https://pagure.io/389-ds-base/issue/51070

Author: aborah

Reviewed by: ???

First of all, please, write the actual docstring here which describes the area you test. BZ Information is not needed here (pytest.mark is enough)

Second, BZ number leads to a WONTFIX bug about abrt-gui-1.0.9-2.fc12.
It is misleading.

I think the file needs to be removed after the end of the test suite.

I think we also need to check the number of users is smaller before the import (it is possible that the number of users before the import == number of users after the import and it still will report a success)

I think we need to check the import log status that it reports success.

I think it can be deleted

1 new commit added

  • Fixing Simon's comments

I think it can be deleted

Removed

I think we need to check the import log status that it reports success.

Done

I think we also need to check the number of users is smaller before the import (it is possible that the number of users before the import == number of users after the import and it still will report a success)

Done

I think the file needs to be removed after the end of the test suite.

Done

First of all, please, write the actual docstring here which describes the area you test. BZ Information is not needed here (pytest.mark is enough)
Second, BZ number leads to a WONTFIX bug about abrt-gui-1.0.9-2.fc12.
It is misleading.

Removed . May be it was a very old bug that is not even listed in modern BZ

LGTM
Ack

rebased onto 74abb90b032556a6c1f3cd39398f9516593332e5

rebased onto 5ae11781e0b8c448687694cb991f4373582fe644

rebased onto 75e3b867d3a879d3490f0497ec4245de75344af2

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4134

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata