389-ds-base

#51053 Issue 51051 - CLI fix consistency issues with confirmations
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue51051  into  master

Download 51053.patch

Description:

The remove-all feature of dsctl uses different confirmation prompt than "dsctl remove". To fix this the "countdown" style confirmation was moved to "remove_all", as "dsctl INST remove" already had an additional argument. See instance.py for these changes.

Also cleaned up unused imports other various bugs found by my IDE.

relates: https://pagure.io/389-ds-base/issue/51050

Just want to know the reasoning behind removing the countdown from singular remove?

Just want to know the reasoning behind removing the countdown from singular remove?

See the bugzilla in the issue, it was discussed there originally (over a year ago when you were MIA). Having an extra flag "--do-it" and a countdown was a bit redundant, and remove-all should have the countdown. If you want the countdown for the single instance removal then we should remove the "--do-it" arg (IMHO).

I'm okay with this, --do-it is enough, it shows intent to actually do the removal. Ack from me.

rebased onto 3def54de447c435009bee65d8e96655fb0236fd4

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4106

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.