389-ds-base

#51036 Ticket 51035 - Heavy StartTLS connection load can randomly fail with err=1
Closed by spichugi. Opened by tbordaz.
tbordaz/389-ds-base ticket_51035  into  master

Download 51036.patch

Bug Description:
startTls pushes a network layer on top of the connection.
So when processing startTLS, there should not be a pending operation
else there is a risk that the operation sends back data on moving
network layer.
When startTls detects a pending operation it aborts startTls.
However if a new operation is received while processing startTls,
the operation is pending but can not be read because startTls
holds c_mutex.

Fix Description:
In case of unread pending operation, relax the control
and just log an information message.

https://pagure.io/389-ds-base/issue/51035

Reviewed by: ?

Platforms tested: F30

Flag Day: no

Doc impact: no

How often could this message be logged? I wonder if it should be SLAPI_LOG_CONN ? And I wonder if the logging call below should also be CONN and not PLUGIN. Thoughts?

Yes, it should be conn, not plugin IMO

rebased onto 5990de8ace882ad50954e11f22685e6c55d0a382

@mreynolds , @firstyear thanks for the reviews. I agree that it makes sense to use connection level rather than plugin. I initially used 'info' because it helps for test purpose and also the failure was quite rare. However, even if it is rare it would be erroneously alarming for administrator. I changed the PR accordingly.

What is up with this include? Looks wrong to me :-)

rebased onto e6023cab66ab258e38efbb009c2d58b8649ce989

ooops .. I have no idea why this include jumped into the patch :)
I removed it

Ack to your patch, but I wonder if we should change all the logging in ldap/servers/slapd/start_tls_extop.c from PLUGIN to CONN? Could do it in a separate issue, but then it might get lost in the mix :-)

Pull-Request has been merged by tbordaz

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4089

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.