#51032 Issue 51031 UI - transition between two instances needs improvement
Closed 3 years ago by spichugi. Opened 4 years ago by mreynolds.
mreynolds/389-ds-base ui-inst  into  master

@@ -332,6 +332,11 @@ 

      }

  

      handleServerIdChange(e) {

+         this.setState({

+             pageLoadingState: { state: "loading", jsx: "" },

+             progressValue: 25,

+             serverId: e.target.value

+         });

          this.loadInstanceList(e.target.value);

      }

  
@@ -625,6 +630,7 @@ 

                                                  addNotification={this.addNotification}

                                                  serverId={this.state.serverId}

                                                  wasActiveList={this.state.wasActiveList}

+                                                 key={this.state.serverId}

                                              />

                                          </TabPane>

                                          <TabPane eventKey={2}>
@@ -632,6 +638,7 @@ 

                                                  addNotification={this.addNotification}

                                                  serverId={this.state.serverId}

                                                  wasActiveList={this.state.wasActiveList}

+                                                 key={this.state.serverId}

                                              />

                                          </TabPane>

                                          <TabPane eventKey={3}>
@@ -639,6 +646,7 @@ 

                                                  addNotification={this.addNotification}

                                                  serverId={this.state.serverId}

                                                  wasActiveList={this.state.wasActiveList}

+                                                 key={this.state.serverId}

                                              />

                                          </TabPane>

                                          <TabPane eventKey={4}>
@@ -646,6 +654,7 @@ 

                                                  addNotification={this.addNotification}

                                                  serverId={this.state.serverId}

                                                  wasActiveList={this.state.wasActiveList}

+                                                 key={this.state.serverId}

                                              />

                                          </TabPane>

                                          <TabPane eventKey={5}>
@@ -653,6 +662,7 @@ 

                                                  addNotification={this.addNotification}

                                                  serverId={this.state.serverId}

                                                  wasActiveList={this.state.wasActiveList}

+                                                 key={this.state.serverId}

                                              />

                                          </TabPane>

                                          <TabPane eventKey={6}>
@@ -660,6 +670,7 @@ 

                                                  addNotification={this.addNotification}

                                                  serverId={this.state.serverId}

                                                  wasActiveList={this.state.wasActiveList}

+                                                 key={this.state.serverId}

                                              />

                                          </TabPane>

                                      </TabContent>

Bug Description

When you switch between instances in the UI, there is no loading page, there is a long wait before the dropdown menu changes, and it does not refresh the page content (it still contains the previous instance's data).

Fix Description

Set the "loading" flag and the serverId right away when instance is changed. Then we set the tab component's key to the server ID so the content is automatically refreshed.

Issue

https://pagure.io/389-ds-base/issue/51031

rebased onto db6cd23

4 years ago

Pull-Request has been merged by mreynolds

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4085

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago
Metadata