389-ds-base

#50983 Issue 49437 - Fix memory leak with indirect COS
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue49437  into  master

Download 50983.patch

Bug Description:

There are two leaks when dealing with indirect COS. The first leak is caused by the COS cache entry's objectclass list not being freed when the entry is removed from the hash table.

The other leak is caused when we follow an indirect pointer COS and do not free a tmp value set that goes unused.

Fix description:

Free the COS entry objectclass list when removing an entry from the hash table. When querying a COS attribute and the returned attribute (out_attr) is NULL, then free the unused tmp_val ValueSet as it's not consumed by anything.

Fixes: https://pagure.io/389-ds-base/issue/49437

Minor nitpick, { } around the vattr_delete_attrvals here.

Besides that I don't see anything wrong with this :) ack

the patch looks good to me as weel. ack

rebased onto 1c06f8c2770ec90a2fdb02653d9a4ade5cc25dff

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4036

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.