389-ds-base

#50978 Issue 50971 - Back out use of `env' and `sed' detection.
Closed by spichugi. Opened by jashankj.
jashankj/389-ds-base jashankj/2020/03/24/env-revert  into  master

Download 50978.patch

Bug Description:

As noted by @vashirov, both Debian and Fedora packaging guidelines forbid use of `env' in Python shebangs.

Fix Description:

Back out parts of changes introduced in PR 50969; these changes will be rolled into the FreeBSD port. FreeBSD users will not be able to build from a tarball.

Relates: https://pagure.io/389-ds-base/issue/50971

Author: Jashank Jeremy (@jashankj)

Review by: [ - ]

Why are you backing out the sed changes too? Shouldn't it just be the env line?

As I noted in https://pagure.io/389-ds-base/issue/50971#comment-635737, the case with buildnum.py is fine, since it's not packaged for the end user to use. This script runs at build time only. So I think it's fine to leave it as it is right now. Same for gsed - this change is good and doesn't break the build.

Yeah, I don't think we need to back this out :)

Pull-Request has been closed by firstyear

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4031

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.