389-ds-base

Clone
Source Code
GIT

#50973 Fix cockpit plugin build
Closed 3 years ago by spichugi. Opened 4 years ago by slev.
slev/389-ds-base fix_cockpit_build  into  master

file modified
+2 -2 
@@ -375,7 +375,7 @@ 
 

                                          checked={db_auto_checked}
 

                                          onChange={this.select_auto_cache}
 

                                      >
 

-                                          Automatic Cache Tuning
 

+                                         Automatic Cache Tuning
 

                                      </Checkbox>
 

                                  </Col>
 

                                  <Col sm={1} />
 
@@ -385,7 +385,7 @@ 
 

                                          checked={import_auto_checked}
 

                                          onChange={ this.select_auto_import_cache}
 

                                      >
 

-                                          Automatic Import Cache Tuning
 

+                                         Automatic Import Cache Tuning
 

                                      </Checkbox>
 

                                  </Col>
 

                              </Row>

file modified
+3 -3 
@@ -223,7 +223,7 @@ 
 

                      <hr />
 

                      <Row>
 

                          <Col componentClass={ControlLabel} sm={2}>
 

-                              Cipher Suite
 

+                             Cipher Suite
 

                          </Col>
 

                          <Col sm={9}>
 

                              <select
 
@@ -239,7 +239,7 @@ 
 

                      </Row>
 

                      <Row className="ds-margin-top">
 

                          <Col componentClass={ControlLabel} sm={2}>
 

-                              Allow Specific Ciphers
 

+                             Allow Specific Ciphers
 

                          </Col>
 

                          <Col sm={9}>
 

                              <Typeahead
 
@@ -257,7 +257,7 @@ 
 

                      </Row>
 

                      <Row className="ds-margin-top">
 

                          <Col componentClass={ControlLabel} sm={2}>
 

-                              Deny Specific Ciphers
 

+                             Deny Specific Ciphers
 

                          </Col>
 

                          <Col sm={9}>
 

                              <Typeahead

There just were indentation issues.

Fixes: https://pagure.io/389-ds-base/issue/50972

Odd, I didn't see these warnings myself, but nice catch, ACK!

But I need you to change the commit message to use our preferred format:

https://www.port389.org/docs/389ds/contributing.html#getting-the-patch-ready

rebased onto 0e1db960b0a7bbb0debfcd1c2a2c908836ae9cc2
4 years ago

@mreynolds, thank you. Updated.

@mreynolds, thank you. Updated.

Looks good, but you should change:

 Reviewed by: ???

to

Reviewed by: mreynolds (Thanks!)

:-)

rebased onto f290163
4 years ago

I thought this is the placeholder to be automatically filled up :-)

I thought this is the placeholder to be automatically filled up :-)

I wish, so I guess it's a bit confusing, the link I sent is how the commit message should look when you send it out for review. Once reviewed and acked you update the "Reviewed by", with the person or persons, who reviewed it. Anyway thanks again, and I get this cherry-picked to all the branches.

Pull-Request has been merged by mreynolds
4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4026

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
3 years ago
Metadata
None
No Tags
Changes Summary 2
+2 -2
file changed
src/cockpit/389-console/src/lib/database/databaseConfig.jsx
+3 -3
file changed
src/cockpit/389-console/src/lib/security/ciphers.jsx
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.