#50922 Issue 50920 - cl-dump exit code is 0 even if command fails with invalid arguments
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base fix-legacy-cl-dump  into  master

Download 50922.patch

Description of problem:
When running the cl-dump.pl script with invalid arguments, the exit code is always 0, even if an error message is reported

Fix Description:
Pass the return code to the end of the #main.

https://pagure.io/389-ds-base/issue/50920

Reviewed by: ?

Could you please adjust our test case too?
https://pagure.io/389-ds-base/blob/master/f/dirsrvtests/tests/suites/replication/changelog_test.py#_278
Thanks!

1 new commit added

  • Fix CI test

Code fix looks good to me

rebased onto 245d8949a3a41604a2eaeab17287051065abdf2b

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3975

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata