PR#50908: Issue 50758 - Only Recommend bash-completion, not Require - 389-ds-base

389-ds-base

#50908 Issue 50758 - Only Recommend bash-completion, not Require

Closed 3 years ago by spichugi. Opened 4 years ago by mhonek.

mhonek/389-ds-base fix-bash-completion-to-recommends into master

Issue 50758 - Only Recommend bash-completion, not Require

Matus Honek • 4 years ago

6fd09c4

rpm/389-ds-base.spec.in

file modified

+1 -1

		`@@ -303,7 +303,7 @@`
		`Requires: python%{python3_pkgversion}-argcomplete`
		`Requires: python%{python3_pkgversion}-libselinux`
		`Requires: python%{python3_pkgversion}-setuptools`
		`- Requires: bash-completion`
		`+ Recommends: bash-completion`
		`%{?python_provide:%python_provide python%{python3_pkgversion}-lib389}`

		`%description -n python%{python3_pkgversion}-lib389`

mhonek commented 4 years ago

Bug Description:
bash-completion package is only useful for interactive use. E.g. in case of a
container deployment this is unnecessary.

Fix Description:
Change Requires to Recommends, which allows the dnf/yum ran with
install_weak_deps=False to not install this package; however, this option is by
default True, therefore a regular installation will install the package.

Relates https://pagure.io/389-ds-base/issue/50758

Author: Matus Honek mhonek@redhat.com

Review by: ???