#50893 Issue 50855 - UI: Port Server Tab to React
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue50855  into  master

Download 50893.patch

Description:

Ported the server tab to reactJS. Also made other changes:

         - Moved Password policy to the database tab tree.
         - Moved the Security Tab to the Server Tab tree.
         - Fixed all the typeAhead errors
         - Removed unused CSS classes
         - Changed Server Tab to use a TreeView

relates: https://pagure.io/389-ds-base/issue/50855

I can not build the server...

Module not found: Error: Can't resolve './server.jsx'

rebased onto 771f52de74da4206e7774cfec73549c2ce80ca6f

I can not build the server...
Module not found: Error: Can't resolve './server.jsx'

Sorry, missed the "git add", fixed now...

Fields for LDAP Port and LDAPS Port accept any character. Can we make it num only?

In Server Settings - Advanced - If I click on Server Read-Only, it doesn't make Save button active.

In Server Settings - Disk Monitoring - I think the fields Disk Monitoring Threshold, Disk Monitoring Grace Period and Server Logs are aligned in an odd way. Maybe, we can put it more to the left (so it's the same level with Enable Disk Space Monitoring? I understand why it is done like this but it really looks off to me...
Attaching a screenshot to the issue.

In Tuning & Limits advanced settings - Enable Normalized DN Cache box has a text field beside it. If we zoom the page just a bit (or user will have a smaller screen to begin with - for me it was broken to begin with), then the field goes to the next line and it looks broken.
Attaching a screenshot to the issue.

In Logging rotation policies, can you please add num limits for Hour and Minute?

rebased onto bb8f26f4f8e7a7d95df0892e987a54472736a730

Fields for LDAP Port and LDAPS Port accept any character. Can we make it num only?

Yup, I missed that.

In Server Settings - Advanced - If I click on Server Read-Only, it doesn't make Save button active.
In Server Settings - Disk Monitoring - I think the fields Disk Monitoring Threshold, Disk Monitoring Grace Period and Server Logs are aligned in an odd way. Maybe, we can put it more to the left (so it's the same level with Enable Disk Space Monitoring? I understand why it is done like this but it really looks off to me...
Attaching a screenshot to the issue.
In Tuning & Limits advanced settings - Enable Normalized DN Cache box has a text field beside it. If we zoom the page just a bit (or user will have a smaller screen to begin with - for me it was broken to begin with), then the field goes to the next line and it looks broken.
Attaching a screenshot to the issue.
In Logging rotation policies, can you please add num limits for Hour and Minute?

These are already number inputs with min and max limits

Changes applied, please review...

I know that you just moved the code but could you please check the Security tab too?

Server Secure Port can be a number also.

And a few checkboxes on the bottom are off in Security Configuration tab (attaching a screenshot)

Require Secure Connections
Verify Certificate Subject Hostname
Allow Weak Ciphers

I am not sure if it was like this before your PR...

The rest looks good as far as I can see.

I know that you just moved the code but could you please check the Security tab too?
Server Secure Port can be a number also.
And a few checkboxes on the bottom are off in Security Configuration tab (attaching a screenshot)
Require Secure Connections
Verify Certificate Subject Hostname
Allow Weak Ciphers

I'll look into this. Did you also check the password policy stuff that got moved to the database tab? Just checking :-)

I'll look into this. Did you also check the password policy stuff that got moved to the database tab? Just checking :-)

Yeah-yeah, it looks good! Interesting solution with 3 tabs for local pwpolicy managment.

I'll look into this. Did you also check the password policy stuff that got moved to the database tab? Just checking :-)

Yeah-yeah, it looks good! Interesting solution with 3 tabs for local pwpolicy management.

I kind of stole the idea from you and what you did with the replication monitor :-) It's tough when a modal is too small for what you need, but I think it works well enough.

rebased onto b206e5997e04fb92e6f601ec4e4e6385b5f94d84

All changes made, and added nsTLSAllowClientRenegotiation to the security page. Please review...

rebased onto c6198c5397d185cf9aeda7e942db952089c613ed

LGTM! Ack

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3946

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata