Bug Description:
The config and FSChecks fail when TLS is not setup
Fix Description:
Properly check for conditions when TLS is not enabled, and ignore errors if TLS related files are not present during the FS permissions check.
relates: https://pagure.io/389-ds-base/issue/50882
rebased onto ea0381f41660981ad34924b640ca7f6e79e6aeae
rebased onto 68a1c77ef0bcdcfe361760d6553673d2fcb499fd
rebased onto e4433b3d6628efc083a10f24d74ee0639e0b4bd6
In this case could we recommend they setup tls? Otherwise ack from me.
I'm on the fence about this one. Should healthcheck complain that you are not using TLS? Doesn't seem to fit in the scope of what healthcheck is really supposed to do. It should not be a "surprise" or an "error" to an Admin that they don't have TLS enabled. Let me sleep on it...
In this case could we recommend they setup tls? Otherwise ack from me. I'm on the fence about this one. Should healthcheck complain that you are not using TLS? Doesn't seem to fit in the scope of what healthcheck is really supposed to do. It should not be a "surprise" or an "error" to an Admin that they don't have TLS enabled. Let me sleep on it...
We can address this in a different ticket is needed. Merging for now as I need to get a build done.
rebased onto 827c97d9d60eadbb3fdd7652635f9e6829b78216
Pull-Request has been merged by mreynolds
Yep fair :)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/3940
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Bug Description:
The config and FSChecks fail when TLS is not setup
Fix Description:
Properly check for conditions when TLS is not enabled, and ignore errors if TLS related files are not present during the FS permissions check.
relates: https://pagure.io/389-ds-base/issue/50882