This code all looks fine, is there a reason not to put it behind -DDEBUG though? IE is there a need for end-users to be able to run this?

This code all looks fine, is there a reason not to put it behind -DDEBUG though? IE is there a need for end-users to be able to run this?

I think we frequently have customer deployments showing issues we cannot reproduce. Being able to run this test could be useful. I would not document it though.

@firstyear , @lkrispen thanks for the review.
From test pov, calling csngen_test could help to detect a regression if csn generator code changes. For example it is easier to simulate remote/offset with this tests than to play with the system time on a test topology. Regarding tests I think some improvements can be done:
- we should create a tool to parse logs can confirm generated CSN always increase
- check generated CSN conforms the csn generator tuning

For detection in customer deployement we also need more work. at the moment it tests adjustment functions with random csn ahead. It would be interesting to see how csn generator behave with adjustment in the past. An other option would be to replay in real time CSN logged in access log.
Running on customer machine it would also be impacted by system time shift.

Okay, I'm happy with this :) It may be good to have lib389 tests and functions related to this too to help us automate this - we can even make tools into the cli that don't list on --help, but could create the test if required.

@firstyear, was it a ack ?

sorry for the delay, the PR got out of my radar but it could now be useful for additional tests with a library playing with the time.

Yes it's an ack, but also would be good to have some lib389 tests for it later too to show it works as you want :)

Thanks. Updated patch with lib389 and testcase :)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3931

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.