#50874 Issue 50873 - Fix issues with healthcheck tool
Closed 3 years ago by spichugi. Opened 4 years ago by mreynolds.
mreynolds/389-ds-base issue50873  into  master

@@ -129,14 +129,18 @@ 

              # No password or we chose to prompt

              dsargs[SER_ROOT_PW] = getpass("Enter password for {} on {}: ".format(dsrc_inst['binddn'], dsrc_inst['uri']))

      elif not ds.can_autobind():

-         # No LDAPI, prompt for password

+         # No LDAPI, prompt for password, and bind DN if necessary

+         if dsrc_inst['binddn'] is None:

+             dn = ""

+             while dn == "":

+                 dn = input("Enter Bind DN: ")

+             dsrc_inst['binddn'] = dn

          dsargs[SER_ROOT_PW] = getpass("Enter password for {} on {}: ".format(dsrc_inst['binddn'], dsrc_inst['uri']))

  

-     if 'binddn' in dsrc_inst:

-         # Allocate is an awful interface that we should stop using, but for now

-         # just directly map the dsrc_inst args in (remember, dsrc_inst DOES

-         # overlay cli args into the map ...)

-         dsargs[SER_ROOT_DN] = dsrc_inst['binddn']

+     # Allocate is an awful interface that we should stop using, but for now

+     # just directly map the dsrc_inst args in (remember, dsrc_inst DOES

+     # overlay cli args into the map ...)

+     dsargs[SER_ROOT_DN] = dsrc_inst['binddn']

  

      ds = DirSrv(verbose=verbose)

      ds.allocate(dsargs)

file modified
+1 -1
@@ -47,7 +47,7 @@ 

  }

  

  DSBLE0003 = {

-     'dsle': 'DSBLE0002',

+     'dsle': 'DSBLE0003',

      'severity': 'LOW',

      'items' : [],

      'detail' : """The backend database has not been initialized yet""",

@@ -6,6 +6,7 @@ 

  # See LICENSE for details.

  # --- END COPYRIGHT BLOCK ---

  

+ import copy

  from lib389._constants import *

  from lib389._mapped_object import DSLdapObject

  from lib389.utils import (ds_is_older)

Description:

  • Wrong error code reported with result for backend check

  • Disk Space Monitor check crashes because it is missing "import copy"

  • On a non-LDAPI instance "dsctl healthcheck" does not prompt for bind dn, only for password.

relates: https://pagure.io/389-ds-base/issue/50873

rebased onto fcd6b2e

4 years ago

Pull-Request has been merged by mreynolds

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3927

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago