389-ds-base

Clone
Source Code
GIT

#50854 Issue 50853 - Fix NULL pointer deref in config setting
Closed 3 years ago by spichugi. Opened 4 years ago by mreynolds.
mreynolds/389-ds-base issue50853  into  master

file modified
+1 -1 
@@ -7957,7 +7957,7 @@ 
 

                  initval = (void *)config_initvalue_to_onoff(cgas, initvalbuf, sizeof(initvalbuf));
 

              } else if (cgas->config_var_type == CONFIG_SPECIAL_FILTER_VERIFY) {
 

                  initval = (void *)config_initvalue_to_special_filter_verify(cgas, initvalbuf, sizeof(initvalbuf));
 

-             } else {
 

+             } else if (cgas->geninitfunc) {
 

                  initval = cgas->geninitfunc();
 

              }
 

              PR_ASSERT(initval);

Description:

Need to check if the config init function is defined for the attribute before blindly calling it. This fixes a regression from issue 48707.

relates: https://pagure.io/389-ds-base/issue/50853

Ack

rebased onto 9b779ed
4 years ago

Pull-Request has been merged by mreynolds
4 years ago

<3 thanks @mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3908

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
3 years ago
Metadata
None
No Tags
Changes Summary 1
+1 -1
file changed
ldap/servers/slapd/libglobs.c
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.