389-ds-base

#50847 Issue 49761 - Fix CI test suite issues
Closed by spichugi. Opened by sgouvern.
sgouvern/389-ds-base rhds_58  into  master

Download 50847.patch

Bug Description:
tickets/ticket48229 test had failures in CI nightly runs

Fix Description:
tickets/ticket48226_test.py file moved and renamed to tests/suite/memory_leaks/MMR_double_free_test.py
Use of Valgrind removed, as support for Valgrind is broken in lib389 - Test run only with ASAN build
Replaced depracated _s functions by use of DSLdapObject

Relates https://pagure.io/389-ds-base/issue/49761

Author: sgouvern

Review by: vashirov, spichugi

This should be a pytest fixture instead of a standalone test.

Here assert can be used instead of try...except.

Please also run git rm -f dirsrvtests/tests/tickets/ticket48226_test.py to remove the old ticket.

Wrong copyright.

And we should use Replica(DSLdapObject) or direct search_s. Legacy Replica will be deprecated soon

Alternatively, you can change the comments to log.info calls. It will be nice, I think :)

Small nitpick, please, change the function name to something meaningful. We already have the Issue name in the pytest.mark

rebased onto 42f7e5f8bfa39e62f350524ca2c3ac7515cfc1cd

Thanks for your reviews.
I updated the PR taking your remarks into account.

LGTM!
Please fix up commits and rebase to master.

rebased onto e48172d9c05d14e8ab8f8ae02a4ba44a9f19b2fa

Done. Thanks !

rebased onto bf8b4af682e275941d3a28476347aba3d4a69c03

Pull-Request has been merged by vashirov

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3901

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.