From e034c291ddfaed6c7ae5b2d30d16cfff5d191c1a Mon Sep 17 00:00:00 2001 From: Mark Reynolds Date: Jan 17 2020 00:41:55 +0000 Subject: Issue 49395 - Set the default TLS version min to TLS1.2 Description: On fedora the NSS default minimum is still TLS1.0, we need to force the default min to be TLS1.2 unless explicity set using sslVersionMin in cn=encryption,cn=config entry. This is also to comply with our healthcheck tool that complains about TLS1.0 min setting. relates: https://pagure.io/389-ds-base/issue/49395 Reviewed by: firstyear (Thanks!) --- diff --git a/ldap/servers/slapd/ssl.c b/ldap/servers/slapd/ssl.c index 6a07f1a..8365b29 100644 --- a/ldap/servers/slapd/ssl.c +++ b/ldap/servers/slapd/ssl.c @@ -48,8 +48,8 @@ * sslVersionMax: max ssl version supported by NSS ******************************************************************************/ -#define DEFVERSION "TLS1.0" -#define CURRENT_DEFAULT_SSL_VERSION SSL_LIBRARY_VERSION_TLS_1_0 +#define DEFVERSION "TLS1.2" +#define CURRENT_DEFAULT_SSL_VERSION SSL_LIBRARY_VERSION_TLS_1_2 extern char *slapd_SSL3ciphers; extern symbol_t supported_ciphers[]; @@ -151,7 +151,7 @@ PRBool enableSSL2 = PR_FALSE; PRBool enableSSL3 = PR_FALSE; /* * nsTLS1: on -- enable TLS1 by default. - * Corresonding to SSL_LIBRARY_VERSION_TLS_1_0 and greater. + * Corresonding to SSL_LIBRARY_VERSION_TLS_1_2 and greater. */ PRBool enableTLS1 = PR_TRUE; @@ -1780,7 +1780,11 @@ slapd_ssl_init2(PRFileDesc **fd, int startTLS) } val = slapi_entry_attr_get_ref(e, "sslVersionMin"); if (val) { + /* Use the user defined minimum */ (void)set_NSS_version((char *)val, &NSSVersionMin, 1); + } else { + /* Force our default minimum */ + (void)set_NSS_version(DEFVERSION, &NSSVersionMin, 1); } val = slapi_entry_attr_get_ref(e, "sslVersionMax"); if (val) {