#50826 Issue 49395 - Set the default TLS version min to TLS1.2
Closed 3 years ago by spichugi. Opened 4 years ago by mreynolds.
mreynolds/389-ds-base issue49395  into  master

file modified
+7 -3
@@ -48,8 +48,8 @@ 

   *   sslVersionMax: max ssl version supported by NSS

   ******************************************************************************/

  

- #define DEFVERSION "TLS1.0"

- #define CURRENT_DEFAULT_SSL_VERSION SSL_LIBRARY_VERSION_TLS_1_0

+ #define DEFVERSION "TLS1.2"

+ #define CURRENT_DEFAULT_SSL_VERSION SSL_LIBRARY_VERSION_TLS_1_2

  

  extern char *slapd_SSL3ciphers;

  extern symbol_t supported_ciphers[];
@@ -151,7 +151,7 @@ 

  PRBool enableSSL3 = PR_FALSE;

  /*

   * nsTLS1: on -- enable TLS1 by default.

-  * Corresonding to SSL_LIBRARY_VERSION_TLS_1_0 and greater.

+  * Corresonding to SSL_LIBRARY_VERSION_TLS_1_2 and greater.

   */

  PRBool enableTLS1 = PR_TRUE;

  
@@ -1780,7 +1780,11 @@ 

          }

          val = slapi_entry_attr_get_ref(e, "sslVersionMin");

          if (val) {

+             /* Use the user defined minimum */

              (void)set_NSS_version((char *)val, &NSSVersionMin, 1);

+         } else {

+             /* Force our default minimum */

+             (void)set_NSS_version(DEFVERSION, &NSSVersionMin, 1);

          }

          val = slapi_entry_attr_get_ref(e, "sslVersionMax");

          if (val) {

Description:

On fedora the NSS default minimum is still TLS1.0, we need to force the default min to be TLS1.2 unless explicitly set using sslVersionMin in cn=encryption,cn=config entry.

This is also to comply with our healthcheck tool that complains about TLS1.0 min setting.

relates: https://pagure.io/389-ds-base/issue/49395

rebased onto e034c29

4 years ago

Pull-Request has been merged by mreynolds

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3880

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago
Metadata