@mreynolds You seem to be the person who knows the most about this area (I think), did you mind taking a look? How would we construct a test to validate this behaviour?

Thanks @yrro for the finding and the patch. IMHO the fix looks good, it was a missing allowed wildcard that only affects the branch checking ip address. The 'host' branch accepts wildcard. Let's wait for @mreynolds final approval.

Not sure why the "*" was removed. @yrro did you confirm if this change works for you? If it works, then this gets my ack.

@mreynolds Is it also worth getting some tests for this later? I'm not sure how we'd do it in py.test, we'd probably need @vashirov's advice here.

We have a test suite for root DN plugin at https://pagure.io/389-ds-base/blob/master/f/dirsrvtests/tests/suites/plugins/rootdn_plugin_test.py

test_rootdn_config_validate can be extended with this particular case.

@yrro Is there anything we can do to help you with the test case development so we can merge this fix :)

I'm sorry to say I just haven't had time to set up an environment to build and run the tests yet, that's all.

This was a fixed in a different PR. Thanks for the contribution, closing this one...

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3857

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.