#50782 Issue 50780 - Fix UI issues
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue50780  into  master

Download 50782.patch

Description:

Fixed issue with replication conflict entry modal, and problem with the monitor's replication and suffix state data collision that cuased a crash if you first looked at replication and then the suffix monitor

relates: https://pagure.io/389-ds-base/issue/50780

I think this approach with repl- unnecessary rises the complexity...

It becomes harder to follow when repl- should be used in the code and when it shouldn't (you don't use it in reloadReplAgmts and reloadReplWinsyncAgmts, for example).

IMO, it'll be better to store all of the suffix data in one state as we do now.

And then we can check if we need to load the database data for suffixes or not:

src/cockpit/389-console/src/monitor.jsx
@@ -352,7 +352,11 @@ 
              };
          });
      } else {
-             if (selectedNode.id in this.state) {
+             if (
+                 selectedNode.id in this.state &&
+                 ("chainingData" in this.state[selectedNode.id] ||
+                     "suffixData" in this.state[selectedNode.id])
+             ) {
                  // This suffix is already cached
                  this.setState(prevState => {
                      return {

Or maybe you can add more comments in the code...

rebased onto 8e6c4920b0b34d48b0468c2027c0057dad1f2f17

@spichugi - changes made please review...

rebased onto 7ffb2eb118acd83f0b941f69bf4a460d91240efd

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3837

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata